[ 
https://issues.apache.org/jira/browse/HDDS-10311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17825896#comment-17825896
 ] 

Will Xiao commented on HDDS-10311:
----------------------------------

Thx [~adoroszlai] , you mean to move the below asserts into 
TestOMBucketCreateRequest.java, as well as the others if it can be moved?
{code:java}
grep -n NumBucketCreates 
./src/test/java/org/apache/hadoop/ozone/om/TestOmMetrics.java
223:    assertCounter("NumBucketCreates", 1L, omMetrics);
272:    assertCounter("NumBucketCreates", 7L, omMetrics);{code}
Also, regarding the first question, any idea why getMetrics in two tests will 
be NullPointer if the cluster is built&started in @BeforeAll

> Speed up TestOmMetrics
> ----------------------
>
>                 Key: HDDS-10311
>                 URL: https://issues.apache.org/jira/browse/HDDS-10311
>             Project: Apache Ozone
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Attila Doroszlai
>            Assignee: Will Xiao
>            Priority: Major
>
> {code}
> Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 115.365 s - 
> in org.apache.hadoop.ozone.om.TestOmMetrics
> {code}
> # assertions about metrics should be merged into functional tests (no need to 
> test e.g. {{listKeys}} and metrics for {{listKeys}} separately
> # no need to start new cluster for each test case



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to