ivandika3 commented on code in PR #5288:
URL: https://github.com/apache/ozone/pull/5288#discussion_r1522469357
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java:
##########
@@ -243,6 +243,10 @@ private OMResponse submitRequestToRatis(OMRequest request)
private OMResponse submitReadRequestToOM(OMRequest request)
throws ServiceException {
+ // Read from leader or followers using linearizable read
+ if (omRatisServer.isLinearizableRead()) {
+ return handler.handleReadRequest(request);
+ }
Review Comment:
Thank you for the info.
> Adding the code here seems incorrect.
I think this can be fixed by also calling `submitRequestToRatis` even on the
read path.
I'm curious, is there any historical reason that currently OM does not send
read request to OM Ratis server? Maybe some overhead consideration? My
understanding is that it should not have a large additional overhead since read
request through Ratis (`StateMachine#query`) does not generate an append log
entry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
