[
https://issues.apache.org/jira/browse/HDDS-10050?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Attila Doroszlai resolved HDDS-10050.
-------------------------------------
Fix Version/s: 1.5.0
Resolution: Done
> Clean up TestStorageContainerManagerHelper
> ------------------------------------------
>
> Key: HDDS-10050
> URL: https://issues.apache.org/jira/browse/HDDS-10050
> Project: Apache Ozone
> Issue Type: Sub-task
> Components: test
> Reporter: Attila Doroszlai
> Assignee: Szabolcs Gál
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> * {{TestStorageContainerManagerHelper}} is a helper class, not a test, so it
> does not match naming conventions. It should be renamed to
> {{StorageContainerManagerTestHelper}}.
> * It has an unused method which can be deleted: {{getPendingDeletionBlocks}}
> * Most methods are only used by {{TestStorageContainerManager}}, could be
> moved there.
> * {{createKeys}} does not need to be an instance method and it could be moved
> (maybe even replaced with existing test data creation utility)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
