ChenSammi commented on PR #6339: URL: https://github.com/apache/ozone/pull/6339#issuecomment-2005689772
> @ChenSammi The major goal of this change is to make S3G more an optional component - if the vault used as S3SecretStore is unavailable, then Ozone should continue to serve clients through the HCFS interface. > > Currently OM fails because of S3G issues, but I going forward I believe this kind of validation should be moved into S3G code. Understand your point. The change in S3GetSecretRequest requires all third party s3 stores' storeSecret an idempotent operation, because it breaks OM transaction value apply order. I'm not sure if Vault's implementation is idempotent or not? And VaultS3SecretStore constructor will be called only one. If anything error happen in VaultS3SecretStore construction, we should throw exception, besides error logging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
