devmadhuu commented on code in PR #6223:
URL: https://github.com/apache/ozone/pull/6223#discussion_r1531502753
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -219,9 +230,10 @@ public void testEmptyMissingContainerDownNode() throws
Exception {
ContainerManager scmContainerManager = scm.getContainerManager();
ReconContainerManager reconContainerManager =
(ReconContainerManager) reconScm.getContainerManager();
+ int previousContainerCount = reconContainerManager.getContainers().size();
ContainerInfo containerInfo =
scmContainerManager
- .allocateContainer(RatisReplicationConfig.getInstance(ONE),
"test");
+ .allocateContainer(RatisReplicationConfig.getInstance(ONE),
"testEmptyMissingContainer");
Review Comment:
If you are increasing datanodes, then better to keep replication factor also
as THREE
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -74,21 +80,22 @@ public void init() throws Exception {
conf.set("ozone.scm.stale.node.interval", "6s");
conf.set("ozone.scm.dead.node.interval", "8s");
- cluster = MiniOzoneCluster.newBuilder(conf).setNumDatanodes(1)
+ cluster = MiniOzoneCluster.newBuilder(conf).setNumDatanodes(3)
Review Comment:
Ok, thanks for the update @raju-balpande , However I am not sure why above
test condition should timeout with just 1 DN in CI and pass in local, because
with 1 DN in cluster, we are shutting down that only DN and so missing
container count should be 1.
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/recon/TestReconTasks.java:
##########
@@ -141,7 +149,7 @@ public void testMissingContainerDownNode() throws Exception
{
(ReconContainerManager) reconScm.getContainerManager();
ContainerInfo containerInfo =
scmContainerManager
- .allocateContainer(RatisReplicationConfig.getInstance(ONE),
"test");
+ .allocateContainer(RatisReplicationConfig.getInstance(ONE),
"testMissingContainer");
Review Comment:
If you are increasing datanodes, then better to keep replication factor also
as THREE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
