ArafatKhan2198 commented on code in PR #6400:
URL: https://github.com/apache/ozone/pull/6400#discussion_r1535103450
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/NSSummaryCLIUtils.java:
##########
@@ -107,8 +108,9 @@ public static String makeHttpCall(StringBuffer url, String
path,
}
}
- public static HashMap<String, Object> getResponseMap(String response) {
- return new Gson().fromJson(response, HashMap.class);
+ public static HashMap<String, Object> getResponseMap(String response)
Review Comment:
Yes thanks, I have completely removed the wrapper now we can directly call
`JsonUtils.readTree(response);` to return a JsonNode and help us out.
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/admin/nssummary/NSSummaryCLIUtils.java:
##########
@@ -107,8 +108,9 @@ public static String makeHttpCall(StringBuffer url, String
path,
}
}
- public static HashMap<String, Object> getResponseMap(String response) {
- return new Gson().fromJson(response, HashMap.class);
+ public static HashMap<String, Object> getResponseMap(String response)
Review Comment:
Yes thanks, I have completely removed the wrapper now we can directly call
`JsonUtils.readTree(response);` to return a JsonNode and help us out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
