sodonnel commented on PR #6385: URL: https://github.com/apache/ozone/pull/6385#issuecomment-2014694683
> Can this be done in a feature branch instead of the master? Right now there is no use of this change and it does not work for FSO and needs more testing. I am pretty strongly against feature branches, because: 1. Nobody reviews changes landing in them except the few people working on them. 2. They are painful to merge to the main branch 3. They are painful to keep up to date with frequent merge conflicts. 4. Merging to the main branch causes a lot of change dumped in all at once. 5. Merging to main requires a vote for a changeset that frankly nobody ever reviews. 6. We have no release in sight for Ozone, so there is plenty of time to add any additional PRs and tests. These changes will do no harm if nobody uses them. We also plan to add FSO support afterward, but this PR is large enough already. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
