siddhantsangwan commented on code in PR #6433:
URL: https://github.com/apache/ozone/pull/6433#discussion_r1538716724
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/ContainerBalancerStopSubcommand.java:
##########
@@ -34,6 +34,7 @@
public class ContainerBalancerStopSubcommand extends ScmSubcommand {
@Override
public void execute(ScmClient scmClient) throws IOException {
+ System.out.println("ContainerBalancer is in stopping state. Waiting for
current iteration to finish");
scmClient.stopContainerBalancer();
System.out.println("Stopping ContainerBalancer...");
Review Comment:
NIT: Maybe I'm being overly technical, but how about:
```
Sending stop command. Waiting for Container Balancer to stop...
```
and then
```
Container Balancer stopped.
```
Balancer doesn't transition to the `STOPPING` state until it has received
the stop command, done some validations (this scm is the leader, balancer is
currently `RUNNING` etc) and persisted some configurations to RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
