hemantk-12 commented on code in PR #6443:
URL: https://github.com/apache/ozone/pull/6443#discussion_r1540150885
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/snapshot/OMSnapshotPurgeResponse.java:
##########
@@ -96,8 +97,9 @@ protected void addToDBBatch(OMMetadataManager
omMetadataManager,
// Delete Snapshot checkpoint directory.
deleteCheckpointDirectory(omMetadataManager, snapshotInfo);
- omMetadataManager.getSnapshotInfoTable().deleteWithBatch(batchOperation,
- dbKey);
+ omMetadataManager.getSnapshotInfoTable().deleteWithBatch(batchOperation,
dbKey);
+ ((OmMetadataManagerImpl) omMetadataManager).getSnapshotChainManager()
+
.deleteSnapshotFromSnapshotIdToTableKey(snapshotInfo.getSnapshotId());
Review Comment:
Reason for the changes, after the change I was seeing an error in
[SnapshotDeletingService](https://github.com/apache/ozone/blob/2f2234c7b61714404399ada8f31b3fb4772b613a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/service/SnapshotDeletingService.java#L167)
if doubleBuffer doesn't get flush by the time next run of the
SnapshotDeletingService starts.
Had an offline discussion and it will fail eventually either here or later
on the purge path. Reverting as suggested.
Thanks @swamirishi for the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
