adoroszlai commented on code in PR #6199:
URL: https://github.com/apache/ozone/pull/6199#discussion_r1540572489
##########
dev-support/ci/selective_ci_checks.bats:
##########
@@ -189,20 +189,17 @@ load bats-assert/load.bash
assert_output -p needs-kubernetes-tests=false
}
-# disabled, because this test fails if
-#
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java
-# is not present in the current tree (i.e. if file is renamed, moved or
deleted)
-#@test "native test in other module" {
-# run dev-support/ci/selective_ci_checks.sh 7d01cc14a6
-#
-# assert_output -p
'basic-checks=["rat","author","checkstyle","findbugs","native","unit"]'
-# assert_output -p needs-build=true
-# assert_output -p needs-compile=true
-# assert_output -p needs-compose-tests=false
-# assert_output -p needs-dependency-check=false
-# assert_output -p needs-integration-tests=false
-# assert_output -p needs-kubernetes-tests=false
-#}
+@test "native test in other module" {
+ run dev-support/ci/selective_ci_checks.sh 822c0dee1a
Review Comment:
This test case verifies that changing a test tagged as `@Native` but outside
of the `hdds-rocks-native` module triggers the `unit (native)` check.
Previously it used:
```
commit 7d01cc14a69cfbad9f5bee3b4f7da0a67c202711
HDDS-8834. Ignore TestManagedSstFileReader#testGetKeyStreamWithTombstone
(#4881)
hadoop-hdds/rocksdb-checkpoint-differ/src/test/java/org/apache/ozone/rocksdb/util/TestManagedSstFileReader.java
| 2 ++
1 file changed, 2 insertions(+)
```
but ddc19e9c1d renamed `TestManagedSstFileReader` to `TestSstFileSetReader`.
When `selective_checks.sh` looks for `@Native` tests, it no longer finds
`TestManagedSstFileReader`, so it does not trigger `unit (native)` for this
specific test class. At the time of ddc19e9c1d I didn't find any other commit
that could be used as a test case, so I had to disable it. Now there is such a
commit:
```
commit 822c0dee1a8fd35ba2a22470e73ebd68b295edd3
HDDS-10148. TestOmSnapshotFsoWithNativeLib should be tagged as native
test (#6160)
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotFsoWithNativeLib.java
| 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
```
This part of the change could be done separately, but I think it's a very
small item that fits here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
