sadanand48 commented on code in PR #6466:
URL: https://github.com/apache/ozone/pull/6466#discussion_r1546272577
##########
hadoop-hdds/tools/src/main/java/org/apache/hadoop/hdds/scm/cli/pipeline/CreatePipelineSubcommand.java:
##########
@@ -37,37 +37,19 @@
versionProvider = HddsVersionProvider.class)
public class CreatePipelineSubcommand extends ScmSubcommand {
- @CommandLine.Option(
- names = {"-t", "--replication-type", "--replicationType"},
- description = "Replication type (STAND_ALONE, RATIS). Full name" +
- " --replicationType will be removed in later versions.",
- defaultValue = "STAND_ALONE"
- )
- private HddsProtos.ReplicationType type;
Review Comment:
Instead of removing the option entirely, a better way would be to keep the
option and throw exception for the STANDALONE case. You could mark hidden=true
which hides the option in the CLI. Keeping the option could make change
backward compatible for scripts that still provide the option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
