sumitagrawl commented on PR #6385: URL: https://github.com/apache/ozone/pull/6385#issuecomment-2032464337
> > @sodonnel If there is snapshot, then having overwrite will actually increase size, as there will be 2 copy - 1 - snapshot and 2 - active db with this solution. > > Correct. This feature, at least initially will only change the latest version of a key. If the key is under a snapshot it will cause the data to be duplicated. @sodonnel IMO, another impacts, - When snapshot is deleted, that key blocks also needs to be deleted. Since no delete event, this will cause orphan blocks (where activeDB key is already overwritten). Need verify if implicitly handled or not (like another client does key overwrite with new set of blocks) - quota size calculation -- Now key type gets changed from Ratis to EC or vice versa, so that impact for used size to be handled while calculating old and new to update difference. - parallel operation -- before overwrite in commit, key gets deleted, so releasing blocks created for overwrite failure -- Do key is present in open key table for this scenario? so that on failure, and cleanup of open key, blocks are released? Any reason of keeping same updateID ? as already we have key overwrite, same logic can follow from server side? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
