hemantk-12 commented on code in PR #6138:
URL: https://github.com/apache/ozone/pull/6138#discussion_r1548352237
##########
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestSnapshotCache.java:
##########
@@ -74,7 +77,8 @@ static void beforeAll() throws Exception {
@BeforeEach
void setUp() {
// Reset cache for each test case
- snapshotCache = new SnapshotCache(cacheLoader, CACHE_SIZE_LIMIT);
+ omMetrics = OMMetrics.create();
Review Comment:
can you please validate the metric in the test as well?
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1829,7 +1829,6 @@ private void updateActiveSnapshotMetrics()
}
}
}
-
Review Comment:
nit: can you please revert this white line change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
