afilpp commented on code in PR #6481:
URL: https://github.com/apache/ozone/pull/6481#discussion_r1553377638


##########
hadoop-ozone/dist/src/main/smoketest/balancer/testBalancer.robot:
##########
@@ -95,15 +95,16 @@ Get Uuid
 Close All Containers
     FOR     ${INDEX}    IN RANGE    15
         ${container} =      Execute          ozone admin container list 
--state OPEN | jq -r 'select(.replicationConfig.replicationFactor == "THREE") | 
.containerID' | head -1
-        EXIT FOR LOOP IF    "${container}" == ""
-                            Execute          ozone admin container close 
"${container}"
+        EXIT FOR LOOP IF    "${container}" == "${EMPTY}"
+                            ${message} =    Execute And Ignore Error    ozone 
admin container close "${container}"
+                            Run Keyword If    '${message}' != '${EMPTY}'      
Should Contain   ${message}   is in closing state
         ${output} =         Execute          ozone admin container info 
"${container}"
                             Should contain   ${output}   CLOS

Review Comment:
   Yes for this test we don't need to wait for the containers to be completely 
closed (this may take too long). Therefore we are happy with both “closed” and 
“closing” statuses.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to