devmadhuu commented on PR #6503: URL: https://github.com/apache/ozone/pull/6503#issuecomment-2046373647
> > 1. replicationType - RATIS > > 2. creationTime - empty string and filter will not be applied, so list out keys irrespective of age, else list out keys which got created on or after provided creationTime > > 3. keySize - 0 bytes, which means all keys greater than zero bytes will be listed, effectively all. > > 4. startPrefix - / > > I think default replication types should be all of them. This is consistent with the key size and create time filters which have no effect if no value is provided. > > > 5. count - 1000 > > ... > > This API will implement pagination support using count params. > > * How can we make sure the user knows the value is truncated and that there is not only 1000 keys in the prefix? > * How is pagination implemented to tell the server where the next 1000 keys should start? 1. Agree, ReplicationType default value can be empty, so listing effectively all. 2. Thinking of providing total count based on filters provided in response, which tells how many keys in the prefix. 3. Still not decided the solution, but I was thinking to provide one more param -> `offset`. So e.g. if client provides `offset` as `0` and count as `10`, then server will give first `10` records. And if client provides `offset` as `100` and count as `50`, then server will skip first `100` records and provides next `50` records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
