ChenSammi commented on code in PR #6495:
URL: https://github.com/apache/ozone/pull/6495#discussion_r1558864250
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/key/OMDirectoriesPurgeResponseWithFSO.java:
##########
@@ -165,6 +167,13 @@ public void processPaths(OMMetadataManager
omMetadataManager,
deletedKey, repeatedOmKeyInfo);
}
+ if (!openKeyRemovalList.isEmpty()) {
+ for (String openKey : openKeyRemovalList) {
+ omMetadataManager.getOpenKeyTable(getBucketLayout()).deleteWithBatch(
+ batchOperation, openKey);
Review Comment:
We should not delete them directly from openKeyTable here. Direct delete
will result in blocks not released, causing orphan blocks. We can mark these
hsynced open key delectable, and modify openKeyCleanupService to delete these
keys and release the blocks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
