xichen01 commented on code in PR #4188: URL: https://github.com/apache/ozone/pull/4188#discussion_r1561142532
########## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java: ########## @@ -1415,7 +1415,7 @@ long generateDiffReport( */ private boolean isKeyModified(OmKeyInfo fromKey, OmKeyInfo toKey) { return !fromKey.isKeyInfoSame(toKey, - false, false, false, false) + false, false, false, false, false) Review Comment: Makes sense, I see the ACL was compared, and the owner may like ACL, how do you think? @hemantk-12 @swamirishi @smengcl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org For additional commands, e-mail: issues-h...@ozone.apache.org