adoroszlai commented on code in PR #6515:
URL: https://github.com/apache/ozone/pull/6515#discussion_r1562583692
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ec/reconstruction/ECReconstructionCoordinator.java:
##########
@@ -323,9 +323,13 @@ public void reconstructECBlockGroup(BlockLocationInfo
blockLocationInfo,
}
// TODO: can be submitted in parallel
for (int i = 0; i < bufs.length; i++) {
- CompletableFuture<ContainerProtos.ContainerCommandResponseProto>
- future = targetBlockStreams[i].write(bufs[i]);
- checkFailures(targetBlockStreams[i], future);
+ if (bufs[i].limit() != 0) {
Review Comment:
While this works OK, I think a better condition would be:
```suggestion
if (bufs[i].remaining() > 0) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
