swamirishi commented on code in PR #6024:
URL: https://github.com/apache/ozone/pull/6024#discussion_r1563348210
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotCache.java:
##########
@@ -185,58 +202,58 @@ public ReferenceCounted<OmSnapshot> get(UUID key) throws
IOException {
* @param key SnapshotId
*/
public void release(UUID key) {
- dbMap.compute(key, (k, v) -> {
- if (v == null) {
- throw new IllegalArgumentException("SnapshotId '" + key + "' does not
exist in cache.");
- } else {
- v.decrementRefCount();
- }
- return v;
- });
-
- // The cache size might have already exceeded the soft limit
- // Thus triggering cleanup() to check and evict if applicable
- cleanup();
+ ReferenceCounted<OmSnapshot> val = dbMap.get(key);
+ if (val == null) {
+ throw new IllegalArgumentException("Key '" + key + "' does not " +
+ "exist in cache.");
+ }
+ val.decrementRefCount();
}
/**
- * Wrapper for cleanupInternal() that is synchronized to prevent multiple
- * threads from interleaving into the cleanup method.
+ * If cache size exceeds soft limit, attempt to clean up and close the
+ instances that has zero reference count.
*/
- private synchronized void cleanup() {
+ private void cleanup() {
if (dbMap.size() > cacheSizeLimit) {
Review Comment:
We can have the soft limit in place. This would ensure that we don't close
snapshots if it is less than soft limit. This would ensure keep at least a few
snapshots open and just do optimistic closing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
