smengcl commented on code in PR #6495:
URL: https://github.com/apache/ozone/pull/6495#discussion_r1566303588
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMDirectoriesPurgeRequestWithFSO.java:
##########
@@ -120,7 +120,11 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager, TermIn
long parentId = keyInfo.getParentObjectID();
dbOpenKey = omMetadataManager.getOpenFileName(path.getVolumeId(),
path.getBucketId(),
parentId, keyInfo.getFileName(), hsyncClientId);
- openKeyRemovalList.add(dbOpenKey);
+ OmKeyInfo openKeyInfo =
omMetadataManager.getOpenKeyTable(getBucketLayout()).get(dbOpenKey);
+ if (openKeyInfo != null) {
+ openKeyInfo.getMetadata().put(DELETED_HSYNC_KEY, "true");
Review Comment:
> will not able to write same key till `openKey` is cleaned up
Got it. So at least in this edge case it won't cause new orphan blocks. But
we should revisit if this is the desired behavior.
Do we have CLI command to manually trigger a run of `OpenKeyCleanup`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
