ivandika3 commented on code in PR #6519:
URL: https://github.com/apache/ozone/pull/6519#discussion_r1566632329


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -709,7 +710,10 @@ private void addKey(ListObjectResponse response, OzoneKey 
next) {
     keyMetadata.setKey(EncodingTypeObject.createNullable(next.getName(),
         response.getEncodingType()));
     keyMetadata.setSize(next.getDataSize());
-    keyMetadata.setETag("" + next.getModificationTime());
+    String eTag = next.getMetadata().get(ETAG);
+    if (eTag != null) {
+      keyMetadata.setETag(eTag);

Review Comment:
   From what I understand the ETag is specified by RFC to always be surrounded 
by double quotes.
   
   Ref: https://github.com/aws/aws-sdk-go-v2/issues/1696
   
   @vtutrinov Could you help confirm this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to