ArafatKhan2198 commented on code in PR #6500:
URL: https://github.com/apache/ozone/pull/6500#discussion_r1567093561
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/events/EventQueue.java:
##########
@@ -205,11 +192,14 @@ public <PAYLOAD, EVENT_TYPE extends Event<PAYLOAD>> void
fireEvent(
for (EventHandler handler : executorAndHandlers.getValue()) {
queuedCount.incrementAndGet();
if (LOG.isTraceEnabled()) {
- LOG.trace(
- "Delivering [event={}] to executor/handler {}:
<json>{}</json>",
- event.getName(),
- executorAndHandlers.getKey().getName(),
- TRACING_SERIALIZER.toJson(payload).replaceAll("\n", "\\\\n"));
+ String jsonPayload = serializeObject(payload);
+ if (jsonPayload != null) {
+ LOG.trace(
+ "Delivering [event={}] to executor/handler {}:
<json>{}</json>",
+ event.getName(),
+ executorAndHandlers.getKey().getName(),
+ jsonPayload.replaceAll("\n", "\\\\n"));
+ }
Review Comment:
If serialization fails, we now log at debug level without payload
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
