sodonnel commented on code in PR #6520:
URL: https://github.com/apache/ozone/pull/6520#discussion_r1567131330
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/ECBlockOutputStream.java:
##########
@@ -115,20 +115,43 @@ ContainerCommandResponseProto> executePutBlock(boolean
close,
}
BlockData checksumBlockData = null;
+ boolean foundStripeChecksum = false;
+ BlockID blockID = null;
//Reverse Traversal as all parity will have checksumBytes
for (int i = blockData.length - 1; i >= 0; i--) {
BlockData bd = blockData[i];
if (bd == null) {
continue;
}
+ if (blockID == null) {
+ // store the BlockID for logging
+ blockID = bd.getBlockID();
+ }
List<ChunkInfo> chunks = bd.getChunks();
- if (chunks != null && chunks.size() > 0 && chunks.get(0)
- .hasStripeChecksum()) {
- checksumBlockData = bd;
- break;
+ if (chunks != null && chunks.size() > 0) {
+ if (chunks.get(0).hasStripeChecksum()) {
+ checksumBlockData = bd;
+ foundStripeChecksum = true;
+ break;
+ } else {
+ ChunkInfo chunk = chunks.get(0);
+ LOG.debug("The first chunk in block with index {} does not have
stripeChecksum. BlockID: {}, Block " +
+ "size: {}. Chunk length: {}, Chunk offset: {},
hasChecksumData: {}, chunks size: {}.", i,
+ bd.getBlockID(), bd.getSize(), chunk.getLen(),
chunk.getOffset(), chunk.hasChecksumData(), chunks.size());
+ }
+
+ if (chunks.get(0).hasChecksumData()) {
+ checksumBlockData = bd;
+ break;
+ }
}
}
+ if (!foundStripeChecksum) {
Review Comment:
I would move this log down to the else statement that is currently at line
184, as that else only executed if `foundStripeChecksum` is false (via
`chunkChecksumData == null`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
