adoroszlai commented on code in PR #6489:
URL: https://github.com/apache/ozone/pull/6489#discussion_r1573827052
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/client/OzoneBucketStub.java:
##########
@@ -210,7 +211,7 @@ public OzoneDataStreamOutput
createMultipartStreamKey(String key,
int partNumber,
String uploadID)
throws IOException {
- String multipartUploadID = multipartUploadIdMap.get(key);
+ String multipartUploadID = keyToMultipartUpload.get(key).getUploadId();
if (multipartUploadID == null || !multipartUploadID.equals(uploadID)) {
Review Comment:
Wouldn't `keyToMultipartUpload.get(key) == null` indicate "no such upload?
We'd hit NPE in that case. I guess `MultipartInfoStub#uploadID` would rarely
be `null`.
(`createMultipartKey` seems to have the correct logic.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
