[ 
https://issues.apache.org/jira/browse/HDDS-10732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17839751#comment-17839751
 ] 

Attila Doroszlai commented on HDDS-10732:
-----------------------------------------

These are generated configs, do not need to be added to {{ozone-default.xml}}.  
Please add the tag in {{OzoneClientConfig}} instead.

{code:title=https://github.com/apache/ozone/blob/8795bcb0fea9bb5705131cabe1ac0ff6abcfc72a/hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/OzoneClientConfig.java#L164-L179}
  @Config(key = "checksum.type",
      defaultValue = "CRC32",
      description = "The checksum type [NONE/ CRC32/ CRC32C/ SHA256/ MD5] "
          + "determines which algorithm would be used to compute checksum for "
          + "chunk data. Default checksum type is CRC32.",
      tags = ConfigTag.CLIENT)
  private String checksumType = ChecksumType.CRC32.name();


  @Config(key = "bytes.per.checksum",
      defaultValue = "1MB",
      type = ConfigType.SIZE,
      description = "Checksum will be computed for every bytes per checksum "
          + "number of bytes and stored sequentially. The minimum value for "
          + "this config is 16KB.",
      tags = ConfigTag.CLIENT)
  private int bytesPerChecksum = 1024 * 1024;
{code}

> Expose client checksum type and bytes per checksum configs to 
> ozone-default.xml
> -------------------------------------------------------------------------------
>
>                 Key: HDDS-10732
>                 URL: https://issues.apache.org/jira/browse/HDDS-10732
>             Project: Apache Ozone
>          Issue Type: Sub-task
>            Reporter: Zita Dombi
>            Assignee: Zita Dombi
>            Priority: Major
>
> There are two config options in OzoneClientConfig: 
> _ozone.client.checksum.type_ and {_}ozone.client.bytes.per.checksum{_}, which 
> are not exposed to ozone-default.xml. In this change I add these there and 
> add the CRYPTO_COMPLIANCE tag to them.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to