szetszwo commented on code in PR #6579:
URL: https://github.com/apache/ozone/pull/6579#discussion_r1576572176
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/BucketArgs.java:
##########
@@ -35,6 +36,7 @@
* This class encapsulates the arguments that are
* required for creating a bucket.
*/
+@Immutable
public final class BucketArgs {
Review Comment:
Checked the fields, we should also mark `DefaultReplicationConfig` as
`@Immutable`.
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/VolumeArgs.java:
##########
@@ -18,13 +18,15 @@
package org.apache.hadoop.ozone.om.helpers;
import com.google.common.base.Preconditions;
+import net.jcip.annotations.Immutable;
import java.util.HashMap;
import java.util.Map;
/**
* A class that encapsulates the createVolume Args.
*/
+@Immutable
public final class VolumeArgs {
Review Comment:
This `VolumeArgs` class is not used anywhere. Let's remove it instead?
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/OzoneAcl.java:
##########
@@ -49,6 +50,7 @@
* <li>world::rw
* </ul>
*/
+@Immutable
public class OzoneAcl {
Review Comment:
The `BitSet` class used by `aclBitSet` is not mutable (and also
inefficient). Our use here is okay since we copy it when needed. We should
get ride of it in a separated JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
