devmadhuu commented on code in PR #6272: URL: https://github.com/apache/ozone/pull/6272#discussion_r1579125821
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/PipelineInfoHandler.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.tasks; + +import org.apache.commons.lang3.tuple.ImmutablePair; +import org.apache.commons.lang3.tuple.Pair; +import org.apache.hadoop.hdds.scm.pipeline.Pipeline; +import org.apache.hadoop.hdds.scm.pipeline.PipelineID; +import org.apache.hadoop.ozone.ClientVersion; +import org.apache.hadoop.ozone.recon.scm.ReconScmMetadataManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.IOException; + +/** + * Manages Pipeline Table info of SCM MetaData DB, updates Recon's in-memory + * Pipeline manager objects. + */ +public class PipelineInfoHandler implements SCMMetaDataTableHandler { + + private static final Logger LOG = + LoggerFactory.getLogger(PipelineInfoHandler.class); + + private ReconScmMetadataManager scmMetadataManager; + + public PipelineInfoHandler(ReconScmMetadataManager scmMetadataManager) { + this.scmMetadataManager = scmMetadataManager; + } + + /** + * Handles a PUT event on scm metadata DB tables. + * + * @param event The PUT event to be processed. + */ + @Override + public void handlePutEvent(RocksDBUpdateEvent<?, Object> event) { + PipelineID pipelineID = (PipelineID) event.getKey(); + Pipeline pipeline = (Pipeline) event.getValue(); + try { + LOG.info("handlePutEvent for add new pipeline event for pipelineId: {}", pipelineID); + handlePutPipelineEvent(pipeline); + } catch (IOException ioe) { + LOG.error("Unexpected error while handling add new pipeline event for pipelineId: {} - ", pipelineID, ioe); + } + } + + private void handlePutPipelineEvent(Pipeline pipeline) throws IOException { + scmMetadataManager.getOzoneStorageContainerManager().getPipelineManager().initialize(pipeline); + } Review Comment: I agree that right now it is just one line code in `handlePutPipelineEvent`, but idea behind separating into a new method is to extend and handle more metrics in future related to pipeline. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
