[
https://issues.apache.org/jira/browse/HDDS-10754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wei-Chiu Chuang updated HDDS-10754:
-----------------------------------
Description:
AbstractContractLeaseRecoveryTest is abstract. No subclasses implements it.
That is to say, Ozone doesn't run lease recovery contract tests. We don't know
if Ozone's lease recovery APIs behavior perform according to the contracts.
https://github.com/apache/ozone/blob/50cd19378253b86685c503437b1d44a8f543ac1f/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/contract/AbstractContractLeaseRecoveryTest.java#L37
IMO, we should just use AbstractContractLeaseRecoveryTest directly from Hadoop
since we use Hadoop 3.3.6 which has this contract test. And then provide an
implementation for Ozone. Something similar to the HDFS contract test in
Hadoop:
https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/contract/hdfs/TestHDFSContractLeaseRecovery.java
was:
AbstractContractLeaseRecoveryTest is abstract. No subclasses implements it.
That is to say, Ozone doesn't run lease recovery contract tests. We don't know
if Ozone's lease recovery APIs behavior perform according to the contracts.
https://github.com/apache/ozone/blob/50cd19378253b86685c503437b1d44a8f543ac1f/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/contract/AbstractContractLeaseRecoveryTest.java#L37
> [hsync] lease recovery contract test class not substantiated
> ------------------------------------------------------------
>
> Key: HDDS-10754
> URL: https://issues.apache.org/jira/browse/HDDS-10754
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: Wei-Chiu Chuang
> Priority: Major
>
> AbstractContractLeaseRecoveryTest is abstract. No subclasses implements it.
> That is to say, Ozone doesn't run lease recovery contract tests. We don't
> know if Ozone's lease recovery APIs behavior perform according to the
> contracts.
> https://github.com/apache/ozone/blob/50cd19378253b86685c503437b1d44a8f543ac1f/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/fs/contract/AbstractContractLeaseRecoveryTest.java#L37
> IMO, we should just use AbstractContractLeaseRecoveryTest directly from
> Hadoop since we use Hadoop 3.3.6 which has this contract test. And then
> provide an implementation for Ozone. Something similar to the HDFS contract
> test in Hadoop:
> https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/contract/hdfs/TestHDFSContractLeaseRecovery.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
