fapifta commented on code in PR #6548:
URL: https://github.com/apache/ozone/pull/6548#discussion_r1579947776
##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/security/ssl/PemFileBasedKeyStoresFactory.java:
##########
@@ -51,7 +51,7 @@ public class PemFileBasedKeyStoresFactory implements
KeyStoresFactory,
/**
* Default format of the keystore files.
*/
- public static final String DEFAULT_KEYSTORE_TYPE = "jks";
+ public static final String DEFAULT_KEYSTORE_TYPE = KeyStore.getDefaultType();
Review Comment:
As I see we use the constant only internally in this class, can we either
inline this, or make it private? I prefer inlining the call, even though it
means calculating the value every time, but the trust/keystores are cached so
it does not happen often, but help us to see all the usages right away when we
check for this method within the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
