smengcl commented on PR #6413: URL: https://github.com/apache/ozone/pull/6413#issuecomment-2089138727
In order to fix the problem where the buffer would be written to by another thread when `currentBuffer` is already submitted to DN, I have forced the `currentBuffer` to be swapped whenever it is submitted to DN. This is done in b6131ff51700d5de99233cc67054910e13425d34. Current issues: 1. The above measure his could cause excessive buffer allocation (increased memory pressure) if: i) DN is slow to respond ii) and client does hsync very frequently Observed `OutOfMemoryError: GC overhead limit exceeded` in `TestOzoneFileSystemWithStreaming` that may not may not be relate to this concern: https://github.com/smengcl/hadoop-ozone/actions/runs/8907642899/job/24462549982 2. More race condition in buffer access that are unresolved. e.g. `TestBlockDeletion.testBlockDeletion`: https://github.com/smengcl/hadoop-ozone/actions/runs/8907642899/job/24462551568#step:6:2352 One more thought: 3. Ditching `watchForCommit` (#6014) first _might_ help in resolving the buffer access race condition -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
