chungen0126 commented on PR #6614: URL: https://github.com/apache/ozone/pull/6614#issuecomment-2091285625
> Why is this targeted at feature branch `HDDS-7593`? `isFileClosed` is already on `master`, it was added for [HDDS-8436](https://issues.apache.org/jira/browse/HDDS-8436). It should be fixed on `master` first. Should I close this pr and create a new one for master? > Also, can you please check if similar usage of `OFSPath` related to snapshots should/can be replaced? > > https://github.com/apache/ozone/blob/fe1b5b63353819acf393398b64ab4152c7e8d51f/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L601 > > https://github.com/apache/ozone/blob/fe1b5b63353819acf393398b64ab4152c7e8d51f/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L610 > > https://github.com/apache/ozone/blob/fe1b5b63353819acf393398b64ab4152c7e8d51f/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L620 > > https://github.com/apache/ozone/blob/fe1b5b63353819acf393398b64ab4152c7e8d51f/hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L665 I fixed those APIs make them create/rename snapshots for the root bucket and add test for them. I'm confused that should them have permission to access snapshots for other buckets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
