DaveTeng0 commented on PR #6608:
URL: https://github.com/apache/ozone/pull/6608#issuecomment-2091944599

   > I think we still need to decide what the CLI for this should look like. We 
could do `ozone {debug,repair} fso-tree` or `ozone repair fso-tree 
[--dry-run]`. Also as we add more of these type of commands I think ones that 
are specific to a component should be under their own subcommand for 
organization, like `ozone repair om fso-tree`.
   > 
   > Attila also brought up the `--dry-run` mode. I think if the command is 
under `repair` only, then dry run would not be the expected default value. If 
we add the read-only invocation under `debug` then that becomes the equivalent 
of dry run and no flag is needed.
   
   Yeah! extracted common codes between FSODebugCLI and FSORepairCLI to 
separated base classes FSOBaseCLI and FSOBaseTool, and make them reuse same 
logic.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to