adoroszlai commented on code in PR #6500:
URL: https://github.com/apache/ozone/pull/6500#discussion_r1588944996
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/scm/container/common/helpers/DeletedBlocksTransactionInfoWrapper.java:
##########
@@ -38,6 +38,12 @@ public DeletedBlocksTransactionInfoWrapper(long txID, long
containerID,
this.localIdList = localIdList;
this.count = count;
}
+ public DeletedBlocksTransactionInfoWrapper() {
Review Comment:
6883aee5ee02825d356ac9a8050312eafdb1b69a removed
`ResetDeletedBlockRetryCountSubcommand` from the PR, maybe accidentally. This
new `DeletedBlocksTransactionInfoWrapper` constructor belongs to that part.
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java:
##########
@@ -144,18 +143,18 @@ public BadFormatException(String msg) {
}
private void processConfigTagRequest(HttpServletRequest request, String cmd,
- Writer out) throws IOException {
- Gson gson = new Gson();
+ Writer out) throws IOException {
Review Comment:
nit: please avoid unnecessary whitespace change (also, such indentation
triggers unnecessary changes, e.g. when method is renamed or visibility updated)
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueContainerMetadataInspector.java:
##########
@@ -181,55 +182,61 @@ public String process(ContainerData containerData,
DatanodeStore store,
return null;
}
- JsonObject containerJson = inspectContainer(kvData, store);
- boolean correct = checkAndRepair(containerJson, kvData, store);
-
- Gson gson = new GsonBuilder()
- .setPrettyPrinting()
- .serializeNulls()
- .create();
- String jsonReport = gson.toJson(containerJson);
- if (log != null) {
- if (correct) {
- log.trace(jsonReport);
- } else {
- log.error(jsonReport);
+ ObjectNode containerJson = inspectContainer(kvData, store);
+ boolean correct = checkAndRepair(containerJson, kvData,
+ store);
Review Comment:
nit: please avoid unrelated formatting change
```suggestion
boolean correct = checkAndRepair(containerJson, kvData, store);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
