ashishkumar50 commented on code in PR #6603:
URL: https://github.com/apache/ozone/pull/6603#discussion_r1590572123
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMAllocateBlockRequest.java:
##########
@@ -208,8 +208,9 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
throw new OMException("Open Key " + openKeyName + " is under lease
recovery",
KEY_UNDER_LEASE_RECOVERY);
}
- if
(openKeyInfo.getMetadata().containsKey(OzoneConsts.DELETED_HSYNC_KEY)) {
- throw new OMException("Open Key " + openKeyName + " is already
deleted",
+ if (openKeyInfo.getMetadata().containsKey(OzoneConsts.DELETED_HSYNC_KEY)
||
+
openKeyInfo.getMetadata().containsKey(OzoneConsts.OVERWRITTEN_HSYNC_KEY)) {
Review Comment:
OVERWRITTEN_HSYNC_KEY is added during commit/hsync. If hsync is not called
and allocate block request is called from client, in the corner case it will
allocate block for both clients. Doesn't impact but an extra block will be
allocated.
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/key/OMKeyCommitRequest.java:
##########
@@ -369,7 +390,7 @@ public OMClientResponse validateAndUpdateCache(OzoneManager
ozoneManager, TermIn
omClientResponse = new OMKeyCommitResponse(omResponse.build(),
omKeyInfo, dbOzoneKey, dbOpenKey, omBucketInfo.copyObject(),
- oldKeyVersionsToDeleteMap, isHSync, newOpenKeyInfo);
+ oldKeyVersionsToDeleteMap, isHSync, newOpenKeyInfo,
dbOpenKeyToDeleteKey, openKeyToDelete);
Review Comment:
Ignore passing `dbOpenKeyToDeleteKey,` can be retrieved using
`openKeyToDelete.`
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/file/OMRecoverLeaseRequest.java:
##########
@@ -225,6 +225,7 @@ private RecoverLeaseResponse doWork(OzoneManager
ozoneManager,
throw new OMException("Open Key " + keyName + " is already deleted",
KEY_NOT_FOUND);
}
+
Review Comment:
Remove unchanged file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
