tanvipenumudy commented on code in PR #6630:
URL: https://github.com/apache/ozone/pull/6630#discussion_r1590612358
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/OzoneDelegationTokenSecretManager.java:
##########
@@ -441,10 +441,12 @@ public boolean verifySignature(OzoneTokenIdentifier
identifier,
signerCert = getCertClient().getCertificate(
identifier.getOmCertSerialId());
} catch (CertificateException e) {
+ LOG.error("getCertificate with identifier {} failed", identifier, e);
Review Comment:
> On the other hand, it may be useful to add some common information from
the token identifier to all four (2 new, 2 existing) messages.
Not sure if there are other fields apart from `omCertSerialId` that can be
added to the 2 existing conditions as well (along with the `signerCert`
information they are already logging).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
