ChenSammi commented on code in PR #6455:
URL: https://github.com/apache/ozone/pull/6455#discussion_r1591761069
##########
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/storage/BlockOutputStream.java:
##########
@@ -178,14 +180,16 @@ public BlockOutputStream(
if (replicationIndex > 0) {
blkIDBuilder.setReplicaIndex(replicationIndex);
}
+ this.directBufferPool = directBufferPool;
this.containerBlockData = BlockData.newBuilder().setBlockID(
blkIDBuilder.build()).addMetadata(keyValue);
// tell DataNode I will send incremental chunk list
- if (config.getIncrementalChunkList()) {
+ if (config.getIncrementalChunkList() && directBufferPool != null) {
Review Comment:
This seems incorrect. If config.getIncrementalChunkList() is true, it
requires a buffer to allocated. If directBufferPool is not null, then the
buffer will come from this pool, otherwise, allocate a buffer instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
