Montura commented on code in PR #6537:
URL: https://github.com/apache/ozone/pull/6537#discussion_r1592007128
##########
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/balancer/TestContainerBalancerDatanodeNodeLimit.java:
##########
@@ -79,6 +96,7 @@ public void
containerBalancerShouldObeyMaxDatanodesToInvolveLimit(@Nonnull Mocke
}
config.setIterations(1);
config.setMaxSizeToMovePerIteration(50 * STORAGE_UNIT);
+ mockedSCM.init(config);
Review Comment:
@Tejaskriya, in some tests we do additional _mock-operations_ for
`MockedSCM` like
[here](https://github.com/apache/ozone/pull/6537/commits/8ededd49881ac60287fb4379161c8ff63eba0beb#diff-c3170fae916a0358ea26ab5520350749eb9ce77de5c7641519fb646f24903098R314).
We have to initialize `MockedSCM` to do **initial mocks** and then add some
more test-specific mocks.
I'll think how to make it better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
