ivandika3 commented on code in PR #6607:
URL: https://github.com/apache/ozone/pull/6607#discussion_r1592589144
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectPut.java:
##########
@@ -193,6 +204,99 @@ void testPutObjectContentLengthForStreaming()
assertEquals(15, getKeyDataSize());
}
+ @Test
+ public void testPutObjectWithTags() throws IOException, OS3Exception {
Review Comment:
Thank you for the review. Updated.
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectPut.java:
##########
@@ -438,6 +542,92 @@ public void
testCopyObjectMessageDigestResetDuringException() throws IOException
}
}
+ @Test
+ public void testCopyObjectWithTags() throws IOException, OS3Exception {
Review Comment:
Updated.
##########
hadoop-ozone/dist/src/main/smoketest/s3/objectputget.robot:
##########
@@ -189,6 +196,16 @@ Create file with user defined metadata size larger than 2
KB
Should contain
${result} MetadataTooLarge
Should not contain
${result} custom-key1: ${custom_metadata_value}
+Create files invalid tags
+ ${result} = Execute AWSS3APICli and checkrc
put-object --bucket ${BUCKET} --key ${PREFIX}/putobject/custom-metadata/key2
--body /tmp/testfile2 --tagging="tag-key1=tag-value1&tag-key1=tag-value2" 255
+ Should contain
${result} InvalidTag
+ ${long_tag_key} = Execute printf
'v%.0s' {1..129}
+ ${result} = Execute AWSS3APICli and checkrc
put-object --bucket ${BUCKET} --key ${PREFIX}/putobject/custom-metadata/key2
--body /tmp/testfile2 --tagging="${long_tag_key}=tag-value1" 255
+ Should contain
${result} InvalidTag
+ ${long_tag_value} = Execute printf
'v%.0s' {1..257}
+ ${result} = Execute AWSS3APICli and checkrc
put-object --bucket ${BUCKET} --key ${PREFIX}/putobject/custom-metadata/key2
--body /tmp/testfile2 --tagging="tag-key1=${long_tag_value}" 255
+ Should contain
${result} InvalidTag
+
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
