sodonnel commented on code in PR #6385:
URL: https://github.com/apache/ozone/pull/6385#discussion_r1592766399
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/rpc/RpcClient.java:
##########
@@ -1671,7 +1708,8 @@ public List<OzoneKey> listKeys(String volumeName, String
bucketName,
key.getModificationTime(),
key.getReplicationConfig(),
key.isFile(),
- key.getOwnerName()))
+ key.getOwnerName(),
+ key.getGeneration()))
Review Comment:
It would be good to include the generation in listKeys too, but perhaps it
is not necessary right now. In the use cases we are thinking of, the user would
need to call getKeyDetails to read the key data anyway.
I will remove this for now, and added another Jira (HDDS-10826) to the epic
to consider adding this to ListKeys(and the Light version), as it might be a
slightly large extra change in this PR right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
