sumitagrawl commented on code in PR #6492:
URL: https://github.com/apache/ozone/pull/6492#discussion_r1593669533
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java:
##########
@@ -246,25 +259,102 @@ public void untarCheckpointFile(File tarFile, Path
destPath)
}
}
+
+ /**
+ * Constructs the full path of a key from its OmKeyInfo using a bottom-up
approach, starting from the leaf node.
+ *
+ * The method begins with the leaf node (the key itself) and recursively
prepends parent directory names, fetched
+ * via NSSummary objects, until reaching the parent bucket (parentId is -1).
It effectively builds the path from
+ * bottom to top, finally prepending the volume and bucket names to complete
the full path. If the directory structure
+ * is currently being rebuilt (indicated by the isRebuilding flag), this
method returns an empty string to signify
+ * that path construction is temporarily unavailable.
+ *
+ * @param omKeyInfo The OmKeyInfo object for the key
+ * @return The constructed full path of the key as a String, or an empty
string if a rebuild is in progress and
+ * the path cannot be constructed at this time.
+ * @throws IOException
+ */
+ public static String constructFullPath(OmKeyInfo omKeyInfo,
+ ReconNamespaceSummaryManager
reconNamespaceSummaryManager,
+ ReconOMMetadataManager
omMetadataManager)
+ throws IOException {
+
+ StringBuilder fullPath = new StringBuilder(omKeyInfo.getKeyName());
+ long parentId = omKeyInfo.getParentObjectID();
+ boolean isDirectoryPresent = false;
+
+ while (parentId != 0) {
+ NSSummary nsSummary =
reconNamespaceSummaryManager.getNSSummary(parentId);
+ if (nsSummary == null) {
+ log.warn("NSSummary tree is currently being rebuilt, returning empty
string for path construction.");
Review Comment:
Directory is in progress for deletion or NSSummary tree creation is in
progress, returning empty path.
For below also, we can have log,
NSSummary tree creation is in progress, returning empty path.
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java:
##########
@@ -414,4 +504,9 @@ public SCMNodeDetails
getReconNodeDetails(OzoneConfiguration conf) {
HddsServerUtil.getReconDataNodeBindAddress(conf));
return builder.build();
}
+
+ @TestOnly
Review Comment:
We use @VisibleForTesting annotation
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/ReconUtils.java:
##########
@@ -81,9 +91,12 @@ public class ReconUtils {
public ReconUtils() {
}
- private static final Logger LOG = LoggerFactory.getLogger(
+ private static Logger log = LoggerFactory.getLogger(
ReconUtils.class);
+ private static AtomicBoolean rebuildTriggered = new AtomicBoolean(false);
+ private static AtomicBoolean isRebuilding = new AtomicBoolean(false);
Review Comment:
unused member isRebuilding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
