devmadhuu commented on code in PR #6583:
URL: https://github.com/apache/ozone/pull/6583#discussion_r1595080169
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconNodeManager.java:
##########
@@ -276,8 +287,15 @@ public RegisteredCommand register(
datanodeDetails.getUuid());
}
}
- return super.register(datanodeDetails, nodeReport, pipelineReportsProto,
- layoutInfo);
+ try {
+ return super.register(datanodeDetails, nodeReport, pipelineReportsProto,
+ layoutInfo);
+ } catch (InvalidTopologyException invalidTopologyException) {
+ LOG.error("InvalidTopologyException error occurred : {}",
invalidTopologyException.getMessage());
+ reconContext.updateHealthStatus(false);
+
reconContext.getErrors().add(ReconContext.ErrorCode.INVALID_NETWORK_TOPOLOGY);
+ }
+ return null;
Review Comment:
As discussed, Recon will continue to return null as Error codes for
RegisteredCommand are not compatible between SCM and Recon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
