xichen01 commented on PR #6655: URL: https://github.com/apache/ozone/pull/6655#issuecomment-2102329910
> Thanks @xichen01 for working on this. > > Can SCM simply always send a limited set of ports (`STANDALONE, RATIS, RATIS_DATASTREAM`) in response to `AllocateBlock` requests? I don't think client needs any other ports. > > It would let us avoid: > > 1. new config > 2. new proto for port names > 3. requiring client to send port names > 4. changing OM requests > > patch: [master...adoroszlai:ozone:dce755c4f3a3e409dfc4b43bc16a48cf2a068842](https://github.com/apache/ozone/compare/master...adoroszlai:ozone:dce755c4f3a3e409dfc4b43bc16a48cf2a068842) CI: https://github.com/adoroszlai/ozone/actions/runs/9004107560 > > > ## How was this patch tested? > > Unit test. Existing test > > To let existing tests cover the changes, we need to set `ozone.client.limit.port.enable=true`. Since the default setting is `false`, they only cover old behavior. Please see failures found by [run with `true`](https://github.com/adoroszlai/ozone/actions/runs/9000547866) in my fork. Some of the failures are due to `RATIS_DATASTREAM` port missing from the limited set. Good idea, I will update this. Do you think that these ports (`STANDALONE`, `RATIS`, `RATIS_DATASTREA`) is enough for Read request (`getContainerWithPipeline`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
