kerneltime commented on PR #6385: URL: https://github.com/apache/ozone/pull/6385#issuecomment-2103481276
> Looking good overall, I think we just need to determine when to call it `rewriteGeneration` and when to just use `generation` from [this thread](https://github.com/apache/ozone/pull/6385#discussion_r1595950688). I still think we need one method used by all tests that defines metadata expectations before and after an overwrite as described in [this comment](https://github.com/apache/ozone/pull/6385#pullrequestreview-2046995945) but if you want to do a follow up PR for that I'm ok. An object should have a `generation` when either metadata or data mutates it should change (ideally increment). We can add sub cases `dataGeneration` and `metadataGeneration`. Qualifying it as `rewriteGeneration` seems superfluous. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
