adoroszlai commented on PR #6673: URL: https://github.com/apache/ozone/pull/6673#issuecomment-2107661771
> The prefix is always non-empty due to the following code, regardless of whether the prefix used. > > https://github.com/apache/ozone/blob/06c7cb419c141a0525c3d91063517b9912c9ff70/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java#L287-L292 > > * It does not impact write op even with a random prefix > * For read op, it always randomly selects an incorrect prefix. > > It seems to require all sub-cmds forced to use prefix. I prefer to allow empty prefixes (e.g. `freon ommg`). @whbing Let me clarify my comment. I think allowing empty prefix is useful to solve problem 2 (random prefix is logged, but not used), but it will not fix problem 1 (reader cannot find data). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
