swamirishi commented on code in PR #6542:
URL: https://github.com/apache/ozone/pull/6542#discussion_r1598751043
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/protocolPB/OzoneManagerProtocolClientSideTranslatorPB.java:
##########
@@ -1354,7 +1354,18 @@ public ListSnapshotResponse listSnapshot(
.map(snapshotInfo -> SnapshotInfo.getFromProtobuf(snapshotInfo))
.collect(Collectors.toList());
- return new ListSnapshotResponse(snapshotInfos, response.hasLastSnapshot()
? response.getLastSnapshot() : null);
+ String lastSnapshot = null;
+
+ if (response.hasLastSnapshot()) {
+ lastSnapshot = response.getLastSnapshot();
+ } else if (snapshotInfos.size() == maxListResult) {
Review Comment:
We are still not aware if there are more entries(total number of snapshots %
maxListResult == 0). We are still back to the same problem where we would be
hitting another OM request after the last page. I am not sure how we can avoid
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
