ChenSammi commented on code in PR #6611:
URL: https://github.com/apache/ozone/pull/6611#discussion_r1599514683
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java:
##########
@@ -590,4 +608,15 @@ public ReplicationServer getReplicationServer() {
return replicationServer;
}
+ public void compactDb() {
+ for (StorageVolume volume : volumeSet.getVolumesList()) {
+ HddsVolume hddsVolume = (HddsVolume) volume;
+ CompletableFuture.runAsync(hddsVolume::compactDb, compactExecutor);
+ // If set dbVolumeSet only need to execute the compact db once
+ if (dbVolumeSet != null) {
Review Comment:
Not fully understand this. For every HddsVolume, there will be one RocksDB.
It's true even when dbVolume is configured.
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java:
##########
@@ -590,4 +608,15 @@ public ReplicationServer getReplicationServer() {
return replicationServer;
}
+ public void compactDb() {
+ for (StorageVolume volume : volumeSet.getVolumesList()) {
+ HddsVolume hddsVolume = (HddsVolume) volume;
+ CompletableFuture.runAsync(hddsVolume::compactDb, compactExecutor);
+ // If set dbVolumeSet only need to execute the compact db once
+ if (dbVolumeSet != null) {
Review Comment:
Not fully understand this. For every HddsVolume, there will be one RocksDB
need compaction. It's true even when dbVolume is configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
