smengcl commented on PR #6667: URL: https://github.com/apache/ozone/pull/6667#issuecomment-2111558036
> > ozonescripts environment has some non-test scripts (start.sh, etc.), these require Docker Compose v2 after the change. > > Can you elaborate on why they require docker compose v2 vs an optional use like the `hadoop-ozone/dist/src/main/compose/testlib.sh` script? Actually `testlib.sh` is already using v2 if it is available. It is a clever trick to override `docker-compose` to use v2 if that is available: https://github.com/apache/ozone/pull/6667/files#diff-f26853740acf7f82a794bddb61e32ae145d12fdb0e08cd4a4c18a991e93742d0R34-R36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
