adoroszlai commented on PR #6689: URL: https://github.com/apache/ozone/pull/6689#issuecomment-2117066818
> It feels a bit strange that it just toggles the rep-config without giving it any parameters though. I simplified the description a bit. :) The command has the same options for replication as `key put`. Since they are optional, the default behavior is just toggling between these two. This behavior is geared towards testing, not for final prod. > optional content and expectedGeneration would only be needed if the content was to be changed I think `expectedGeneration` could be added to `key put` instead, which already has argument for content to be uploaded, and already overwrites key if it exists. The new option would be a safety net, similar to `git push --force-with-lease`. `key rewrite` would be a simpler "just change replication to ...". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
