duongkame commented on code in PR #6693:
URL: https://github.com/apache/ozone/pull/6693#discussion_r1605403125
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java:
##########
@@ -807,20 +814,13 @@ public CompletableFuture<Void> flush(long index) {
* which can be null if this method is invoked after {@link
#applyTransaction(TransactionContext)}.
*/
@Override
- public CompletableFuture<ByteString> read(LogEntryProto entry,
TransactionContext trx) {
+ public CompletableFuture<ReferenceCountedObject<ByteString>>
retainRead(LogEntryProto entry,
+ TransactionContext trx) {
metrics.incNumReadStateMachineOps();
- final ByteString dataInContext = Optional.ofNullable(trx)
Review Comment:
We can turn back to using dataInContext after RATIS-2094.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
