ivandika3 commented on code in PR #6696:
URL: https://github.com/apache/ozone/pull/6696#discussion_r1607480312
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/ClosePipelineCommandHandler.java:
##########
@@ -122,19 +125,37 @@ public void handle(SCMCommand command, OzoneContainer
ozoneContainer,
} catch (GroupMismatchException ae) {
// ignore silently since this means that the group has
been closed by earlier close pipeline
// command in another datanode
+ LOG.debug("Failed to remove group {} for pipeline {} on
peer {} since the group has " +
+ "been removed by earlier close pipeline command
handled in another datanode", raftGroupId,
+ pipelineID, peer.getId());
} catch (IOException ioe) {
- LOG.warn("Failed to remove group {} for peer {}",
raftGroupId, peer.getId(), ioe);
+ LOG.warn("Failed to remove group {} of pipeline {} on peer
{}",
+ raftGroupId, pipelineID, peer.getId(), ioe);
}
});
}
+ // Remove the Ratis group from the current datanode pipeline, might
throw GroupMismatchException as
+ // well. It is a no-op for XceiverServerSpi implementations (e.g.
XceiverServerGrpc)
+ server.removeGroup(pipelineIdProto);
LOG.info("Close Pipeline {} command on datanode {}.", pipelineID,
dn.getUuidString());
} else {
- LOG.debug("Ignoring close pipeline command for pipeline {} " +
- "as it does not exist", pipelineID);
+ LOG.debug("Ignoring close pipeline command for pipeline {} on
datanode {} " +
+ "as it does not exist", pipelineID, dn.getUuidString());
}
+ } catch (GroupMismatchException gme) {
+ // ignore silently since this means that the group has been closed by
earlier close pipeline
+ // command in another datanode
+ LOG.debug("The group for pipeline {} on datanode {} has been removed
by earlier close " +
+ "pipeline command handled in another datanode", pipelineID,
dn.getUuidString());
Review Comment:
Thank you for the review. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
